Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 )
Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable ...................................................................... Patch Set 1: (1 comment) I only had one minor comment but other than that it LGTM. http://gerrit.cloudera.org:8080/#/c/10654/1/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java File fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java: http://gerrit.cloudera.org:8080/#/c/10654/1/fe/src/main/java/org/apache/impala/planner/HdfsPartitionPruner.java@455 PS1, Line 455: if (p.isDefaultPartition()) continue; It doesn't seem related to the changes of this commit and it might change the behavior of this method. Could you add a comment why can we skip the default partition? -- To view, visit http://gerrit.cloudera.org:8080/10654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5a480e570aeae565fafd4f3e2b279e7a98c7da Gerrit-Change-Number: 10654 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Sun, 10 Jun 2018 18:28:13 +0000 Gerrit-HasComments: Yes
