Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/10654 )
Change subject: IMPALA-7121: Clean up partitionIds_ from HdfsTable ...................................................................... Patch Set 2: (1 comment) Thanks for taking a look Todd and Tim! I'll take a quick look at the review you mentioned. I feel that these 2 should be easily merged once the other makes to to the repo. http://gerrit.cloudera.org:8080/#/c/10654/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10654/2//COMMIT_MSG@16 PS2, Line 16: One thing needs extra attention here is that modifying the result of > It looks like this adds an extra copy in a lot of cases though, e.g. I'm not sure I get the point. I have replace all the matchingIds.addAll(tbl_.getPArtitionIds()) not to copy the result to this: matchingIds = tbl_.getPartitionIds() Copy inside getPartitionIds() is needed for two reasons: - To guarantee that partitionMap_.keySet() is not altered on the callsites. For this Collections.unmodifiableSet() would be a solution. - To remove the 'default partition' from the set that we return. I can't do that in partitionMap_ so I have to make a copy and remove that dummy partition from that. Am I missing something? -- To view, visit http://gerrit.cloudera.org:8080/10654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8b5a480e570aeae565fafd4f3e2b279e7a98c7da Gerrit-Change-Number: 10654 Gerrit-PatchSet: 2 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 14 Jun 2018 10:46:56 +0000 Gerrit-HasComments: Yes
