Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22462/3/be/src/rpc/auth-provider.h File be/src/rpc/auth-provider.h: http://gerrit.cloudera.org:8080/#/c/22462/3/be/src/rpc/auth-provider.h@179 PS3, Line 179: std::unique_ptr<AuthenticationHash> hash_; > It does not appear to be doing that. Actually allowing the last hash for an unlimited period seems to contradict reasons you'd want to rotate the hash (security). You'd have to rotate twice before you disabled a compromised hash. http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@987 PS3, Line 987: final String[] cookie = new String[1]; > I'm not sure why this is a final String[]. Is it because the variable has Yes. http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@1004 PS3, Line 1004: TCLIService.Iface client = new TCLIService.Client(new TBinaryProtocol(transport)); > Will this always connect over port 28000? My concern is if the connection Yes, it uses a transport connecting to port 28000. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 26 Aug 2025 23:47:46 +0000 Gerrit-HasComments: Yes
