Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22462 )
Change subject: IMPALA-13687: Support shared secret key for cookies ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java File fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java: http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@1019 PS3, Line 1019: verifyCookieMetrics(2, 0); > Move this statement outside the try block to handle the case where execAndF I don't understand the concern. There's no catch block, so if an exception is thrown before this line, it doesn't matter whether it's inside or outside the try block. http://gerrit.cloudera.org:8080/#/c/22462/3/fe/src/test/java/org/apache/impala/customcluster/LdapHS2Test.java@1035 PS3, Line 1035: assertEquals(1, actualCookieAuthSuccess); > Should be able to replace with a call to verifyCookieMetrics(1, 0) These helpers use client_ rather than webClient. I could rework the methods to accept a client argument, but it's not a lot of code and it would only be used here. -- To view, visit http://gerrit.cloudera.org:8080/22462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2e2345f771608069407e9dcf7ed4697fc0214e7 Gerrit-Change-Number: 22462 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 27 Aug 2025 20:19:30 +0000 Gerrit-HasComments: Yes
