Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23354 )

Change subject: IMPALA-14295: [WIP] Support table masking for the Calcite 
planner
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23354/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java:

http://gerrit.cloudera.org:8080/#/c/23354/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@267
PS2, Line 267:           String sql = "SELECT CAST(CAST(id AS BIGINT) * 
CAST(111 AS BIGINT) AS INT) id " +
line too long (91 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23354
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b6a66157ec14cfb453079e7ee842dc9add5fe1d
Gerrit-Change-Number: 23354
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 05 Sep 2025 20:47:11 +0000
Gerrit-HasComments: Yes

Reply via email to