Fang-Yu Rao has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23383 )

Change subject: IMPALA-14295: [WIP] Support table masking for the Calcite 
planner
......................................................................


Patch Set 5:

(1 comment)

> Patch Set 4:
>
> (1 comment)

Patch set 5 resolved the issue described in 
https://gerrit.cloudera.org/c/23383/4 by re-validating the validated AST when 
table masking is required for at least 1 table in the query.

http://gerrit.cloudera.org:8080/#/c/23383/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java
File 
java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java:

http://gerrit.cloudera.org:8080/#/c/23383/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/ImpalaSqlValidatorImpl.java@293
PS4, Line 293:  Note that for a given table/view against which there are column 
masking
> I have verified that if we change this statement to the following, then the
It looks like the issue could be resolved if we re-validate the validated AST 
when there is at least one table in the query that requires table masking. 
Refer to https://gerrit.cloudera.org/c/23383/5 for more details.



--
To view, visit http://gerrit.cloudera.org:8080/23383
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d9cf028078762f78cf0f82b817bdc1ee37e180b
Gerrit-Change-Number: 23383
Gerrit-PatchSet: 5
Gerrit-Owner: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:02:28 +0000
Gerrit-HasComments: Yes

Reply via email to