Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )
Change subject: IMPALA-14446: Clean up pom.xml ...................................................................... Patch Set 4: (2 comments) Thanks for taking care of this Michael! I left 2 minor comments. http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a183 PS3, Line 183: : : : : : : : : : : This is just for my own understanding. Is it true that the current Ranger dependency no longer pulls in log4j-1.2-api or log4j, so it's safe to remove these 2 exclusions? I am asking this because it seems these 2 artifacts are still banned. Not very sure if I missed something. http://gerrit.cloudera.org:8080/#/c/23432/3/fe/pom.xml@a198 PS3, Line 198: : : : > Are notes like this important to preserve, or they does not matter anymore? If we remove this exclusion then the note about RANGER-1837 won't matter anymore. > The question is does Ranger include anything besides orc-core, since we > include it explicitly. I didn't see evidence they did. It wouldn't hurt to > add it back I suppose. Laszlo authored https://github.com/apache/impala/commit/85e1a3e33b9a3f55684e321f5ad180d4fc04c5ad that added this exclusion. It seems the Ranger dependency could pull in a different version of ORC that might not be compatible with the Iceberg dependency needed by Impala. I guess we want to keep this exclusion? Maybe we should consult Laszlo about this too. -- To view, visit http://gerrit.cloudera.org:8080/23432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0 Gerrit-Change-Number: 23432 Gerrit-PatchSet: 4 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 18 Sep 2025 00:41:22 +0000 Gerrit-HasComments: Yes
