Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23432 )
Change subject: IMPALA-14446: Clean up pom.xml ...................................................................... Patch Set 7: > Patch Set 7: > > (1 comment) Thank you for checking those. I am slightly concerned about the commons-dbcp2 version downgrade. Per the release notes at https://commons.apache.org/proper/commons-dbcp/changes-report.html, there are no major changes between 2.9.0 and 2.12, but there are a lot of bug fixes. Would you be ok with bumping the IMPALA_DBCP2_VERSION env var from 2.9.0 to 2.12? My concern is introducing difficult to debug issues because a bug fix is now gone from commons-dbcp. I know it's not a pom fix, thus tackling it in another change works too. -- To view, visit http://gerrit.cloudera.org:8080/23432 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If96649840e23036b4a73ee23e8d12516497994f0 Gerrit-Change-Number: 23432 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Sep 2025 15:37:40 +0000 Gerrit-HasComments: No
