Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23316 )
Change subject: IMPALA-14106: Calcite planner: Register equivalent union expressions in value transfer graph ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java: http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@85 PS2, Line 85: registerUnionValueTransfers(analyzer, outputExprs, childrenPlanNodes); > Is there any additional check to be done for Union Distinct vs Union All ? Good point. Just added it. http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@119 PS2, Line 119: * Register the union value transfers which allows runtime filter generators > Could you expand the comments to indicate that the value transfer is only b Done http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@134 PS2, Line 134: SlotRef inputExpr = nodeWithExprs.outputExprs_.get(i).unwrapSlotRef(false); > My understanding is that the slotRef of the left child of a UnionAll is the It does create a new TupleDescriptor which I believe creates new SlotDescriptors and new SlotRefs. If I am understand you correctly, I'm not sure if that's possible? Are you suggesting that one copy can be prevented? Not sure how that would work across multiple nodes, but I can do some research. Perhaps I should file a Jira? -- To view, visit http://gerrit.cloudera.org:8080/23316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c858ae82a1cb7b89b0ae4e70205d8eeaeb28687 Gerrit-Change-Number: 23316 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 22 Sep 2025 18:10:22 +0000 Gerrit-HasComments: Yes
