Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23316 )
Change subject: IMPALA-14106: Calcite planner: Register equivalent union expressions in value transfer graph ...................................................................... Patch Set 3: Code-Review+2 (3 comments) LGTM. http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java: http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@85 PS2, Line 85: if (unionAll) { > Good point. Just added it. Done http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@119 PS2, Line 119: > Done Done http://gerrit.cloudera.org:8080/#/c/23316/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/NodeCreationUtils.java@134 PS2, Line 134: for (int i = 0; i < outputExprs.size(); ++i) { > It does create a new TupleDescriptor which I believe creates new SlotDescri If a new TupleDescriptor is created, then what you have is fine. Marking this done for now. -- To view, visit http://gerrit.cloudera.org:8080/23316 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4c858ae82a1cb7b89b0ae4e70205d8eeaeb28687 Gerrit-Change-Number: 23316 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 23 Sep 2025 23:59:08 +0000 Gerrit-HasComments: Yes
