Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23317 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 9: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23317/9/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java File fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java: http://gerrit.cloudera.org:8080/#/c/23317/9/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@122 PS9, Line 122: List<PartitionLimit> perPartitionLimits = inferPartitionLimits(analyzer_, analyticConjs); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23317/9/fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java@942 PS9, Line 942: public static List<PartitionLimit> inferPartitionLimits(Analyzer analyzer, List<Expr> conjuncts) { line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/23317/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java: http://gerrit.cloudera.org:8080/#/c/23317/9/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaAnalyticRel.java@560 PS9, Line 560: public Expr overrideSelectivityIfNecessary(Expr filterConj, List<Expr> overrideConjuncts) { line too long (93 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fa6781db56771b13b0cf49bd236f776016bf8d Gerrit-Change-Number: 23317 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 01:17:51 +0000 Gerrit-HasComments: Yes
