Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23317 )
Change subject: IMPALA-14115: Calcite planner: Added top-n analytic PlanNode optimization. ...................................................................... Patch Set 14: Code-Review+1 (1 comment) Overall, this lgtm. Doing a +1 and can bump it based on the jenkins run. http://gerrit.cloudera.org:8080/#/c/23317/10/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test File testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test: http://gerrit.cloudera.org:8080/#/c/23317/10/testdata/workloads/functional-planner/queries/PlannerTest/calcite_tpcds/tpcds-q02.test@276 PS10, Line 276: | | build expressions: tpcds_partitioned_parquet_snap.date_dim_1.d_week_seq > The change that caused this was the RexCallConverter.shouldFlipExpr. My guess is the 'param0.unwrapSlotRef(false) == null ...' check in the other NormalizeBinaryPredicatesRule rule might be needed for some use case (not for TPC-DS) .. but let's check with the full jenkins run. -- To view, visit http://gerrit.cloudera.org:8080/23317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6fa6781db56771b13b0cf49bd236f776016bf8d Gerrit-Change-Number: 23317 Gerrit-PatchSet: 14 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 00:00:50 +0000 Gerrit-HasComments: Yes
