Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/23493 )
Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23493/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java: http://gerrit.cloudera.org:8080/#/c/23493/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeKuduDDLTest.java@394 PS1, Line 394: AnalyzesOk("create table tab (x ARRAY<INT> primary key) " + : "partition by hash(x) partitions 3 stored as kudu", : isExternalPurgeTbl > As of now, I'm not sure Kudu actually works as expected with array columns I think there is a TODO from Kudu on both: Can array columns be a part of primary key? Can array columns be a part of partition key? http://gerrit.cloudera.org:8080/#/c/23493/1/testdata/cluster/node_templates/common/etc/kudu/master.conf.tmpl File testdata/cluster/node_templates/common/etc/kudu/master.conf.tmpl: http://gerrit.cloudera.org:8080/#/c/23493/1/testdata/cluster/node_templates/common/etc/kudu/master.conf.tmpl@26 PS1, Line 26: cfile_support_arrays This is not needed anymore as of commit here(doesn't hurt to have it): https://github.com/apache/kudu/commit/2aafa5352e8faf6d4666af39d5c0af9c2d7324c9 http://gerrit.cloudera.org:8080/#/c/23493/1/testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl File testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl: http://gerrit.cloudera.org:8080/#/c/23493/1/testdata/cluster/node_templates/common/etc/kudu/tserver.conf.tmpl@32 PS1, Line 32: cfile_support_arrays same as before -- To view, visit http://gerrit.cloudera.org:8080/23493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310 Gerrit-Change-Number: 23493 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Fri, 03 Oct 2025 23:45:02 +0000 Gerrit-HasComments: Yes
