Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/23493 )
Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc File be/src/exec/kudu/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc@400 PS5, Line 400: RawValue::Write(&tv, kudu_tuple, slot, nullptr); Could use writeNotNull() here if you make it public. http://gerrit.cloudera.org:8080/#/c/23493/5/be/src/exec/kudu/kudu-scanner.cc@476 PS5, Line 476: memset(result.ptr, 0, total_tuple_byte_size); Is this zeroing needed? IF so, we should make just zero trailing bytes and the null case. http://gerrit.cloudera.org:8080/#/c/23493/5/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java File fe/src/main/java/org/apache/impala/catalog/KuduColumn.java: http://gerrit.cloudera.org:8080/#/c/23493/5/fe/src/main/java/org/apache/impala/catalog/KuduColumn.java@89 PS5, Line 89: Type type = KuduUtil.toImpalaType(colSchema); Move this into the conditional branch below. -- To view, visit http://gerrit.cloudera.org:8080/23493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310 Gerrit-Change-Number: 23493 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 23:17:23 +0000 Gerrit-HasComments: Yes
