Hello Mihaly Szjatinya, Noemi Pap-Takacs, Michael Smith, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23537
to look at the new patch set (#2).
Change subject: IMPALA-14496: Impala crashes when it writes multiple delete
files per partition in a single DELETE operation
......................................................................
IMPALA-14496: Impala crashes when it writes multiple delete files per partition
in a single DELETE operation
Impala crashes when it needs to write multiple delete files per
partition in a single DELETE operation. It is because
IcebergBufferedDeleteSink has its own DmlExecState object, but
sometimes the methods in TableSinkBase use the RuntimeState's
DmlExecState object. I.e. it can happen that we add a partition
to the IcebergBufferedDeleteSink's DmlExecState, but later we
expect to find it in the RuntimeState's DmlExecState.
This patch adds new methods to TableSinkBase that are specific
for writing delete files, and they always take a DmlExecState
object as a parameter. They are now used by IcebergBufferedDeleteSink.
Testing
* added e2e tests
Change-Id: I46266007a6356e9ff3b63369dd855aff1396bb72
---
M be/src/exec/iceberg-buffered-delete-sink.cc
M be/src/exec/table-sink-base.cc
M be/src/exec/table-sink-base.h
A
testdata/workloads/functional-query/queries/QueryTest/iceberg-multiple-delete-per-partition.test
M tests/query_test/test_iceberg.py
5 files changed, 142 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/37/23537/2
--
To view, visit http://gerrit.cloudera.org:8080/23537
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I46266007a6356e9ff3b63369dd855aff1396bb72
Gerrit-Change-Number: 23537
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]>
