Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23537 )
Change subject: IMPALA-14496: Impala crashes when it writes multiple delete files per partition in a single DELETE operation ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23537/3/be/src/exec/table-sink-base.cc File be/src/exec/table-sink-base.cc: http://gerrit.cloudera.org:8080/#/c/23537/3/be/src/exec/table-sink-base.cc@443 PS3, Line 443: if (partition->tmp_hdfs_file == nullptr && !is_overwrite()) return Status::OK(); nit: we could combine most of these functions into a helper that takes state->dml_exec_state() and is_delete as arguments. -- To view, visit http://gerrit.cloudera.org:8080/23537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46266007a6356e9ff3b63369dd855aff1396bb72 Gerrit-Change-Number: 23537 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 14 Oct 2025 16:52:26 +0000 Gerrit-HasComments: Yes
