Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23457 )

Change subject: IMPALA-14287: Resolve environment variables in REST server 
configurations
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23457/2/fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java
File 
fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java:

http://gerrit.cloudera.org:8080/#/c/23457/2/fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java@165
PS2, Line 165:         "path=${ENV:PATH}/dir 
${ENV:FAKE}\nconnector.name=iceberg\niceberg.catalog.type=rest\n");
line too long (97 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23457
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3faccc15d012c389703c58371a4d38cca82bef60
Gerrit-Change-Number: 23457
Gerrit-PatchSet: 2
Gerrit-Owner: Peter Rozsa <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 24 Sep 2025 11:50:26 +0000
Gerrit-HasComments: Yes

Reply via email to