Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23457 )
Change subject: IMPALA-14287: Resolve environment variables in REST server configurations ...................................................................... Patch Set 3: (2 comments) Thanks for working on this! http://gerrit.cloudera.org:8080/#/c/23457/3/fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java File fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java: http://gerrit.cloudera.org:8080/#/c/23457/3/fe/src/main/java/org/apache/impala/service/catalogmanager/ConfigLoader.java@93 PS3, Line 93: envVarValue != null I think we should log an error when envVarValue is NULL. It will make it obvious when there's a configuration/setup issue. http://gerrit.cloudera.org:8080/#/c/23457/3/fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java File fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java: http://gerrit.cloudera.org:8080/#/c/23457/3/fe/src/test/java/org/apache/impala/service/catalogmanager/ConfigLoaderTest.java@165 PS3, Line 165: ${ENV:PATH}/dir ${ENV:FAKE} We could have another test where we have multiple valid environment variables. USER/SHELL/HOME should be always defined. -- To view, visit http://gerrit.cloudera.org:8080/23457 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3faccc15d012c389703c58371a4d38cca82bef60 Gerrit-Change-Number: 23457 Gerrit-PatchSet: 3 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 25 Sep 2025 09:50:06 +0000 Gerrit-HasComments: Yes
