Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23542 )

Change subject: IMPALA-14493: Cap memory usage of global admission service
......................................................................


Patch Set 1:

Thanks for the review. The major memory usage for admissiond can be for 
deserializing the sidecar stuff to read and hold like below. This seems to be 
related to IMPALA-14499, as the memory tracker doesn't function correctly in 
admissiond. Using tcmalloc stats as a cap is a simpler and safer way to prevent 
OOM errors for now.
Total: 631.5 MB
   200.0  31.7%  31.7%    200.0  31.7% std::vector::_M_default_append (inline)
   100.0  15.8%  47.5%    100.0  15.8% 
google::protobuf::Arena::CreateMaybeMessage (inline)
   ...
     0.0   0.0% 100.0%    217.0  34.4% 
impala::AdmissionControlService::AdmitQuery
   ...
     0.0  0.0% 100.0%  217.0 34.4% impala::GetSidecar
   ...
     0.0   0.0% 100.0%    217.0  34.4% impala::TQueryExecRequest::read
     ...
     0.0   0.0% 100.0%    199.0  31.5% impala::TScanRangeSpec::read
     0.0   0.0% 100.0%    187.0  29.6% impala::TScanRangeSpec::read (inline)


--
To view, visit http://gerrit.cloudera.org:8080/23542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee2c942a73fcd69358851fc2fdc0fc4fe531c73
Gerrit-Change-Number: 23542
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 14 Oct 2025 22:42:49 +0000
Gerrit-HasComments: No

Reply via email to