Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23542 )

Change subject: IMPALA-14493: Cap memory usage of global admission service
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/23542/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23542/1//COMMIT_MSG@9
PS1, Line 9: experience OOM error
> experience OOM errors under high concurrency
Done


http://gerrit.cloudera.org:8080/#/c/23542/1/be/src/scheduling/admission-controller.cc
File be/src/scheduling/admission-controller.cc:

http://gerrit.cloudera.org:8080/#/c/23542/1/be/src/scheduling/admission-controller.cc@272
PS1, Line 272:     "Admission rejected due to memory pressure in admissiond. 
Current usage: $0 bytes, "
> Maybe clarify this is admissiond memory pressure?
Done


http://gerrit.cloudera.org:8080/#/c/23542/1/be/src/scheduling/admissiond-env.h
File be/src/scheduling/admissiond-env.h:

http://gerrit.cloudera.org:8080/#/c/23542/1/be/src/scheduling/admissiond-env.h@85
PS1, Line 85: a value
            :   /// over 0, new admission requests are rejected when the 
tcmalloc in-use bytes are over
            :   /// this limit.
> a value over 0, new admission requests are rejected when the tcmalloc in-us
Done



--
To view, visit http://gerrit.cloudera.org:8080/23542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2ee2c942a73fcd69358851fc2fdc0fc4fe531c73
Gerrit-Change-Number: 23542
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Tue, 21 Oct 2025 23:51:20 +0000
Gerrit-HasComments: Yes

Reply via email to