Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23204 )
Change subject: IMPALA-14234: Fix a version mismatch DCHECK hit when admissiond cluster membership recovering ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/23204/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23204/5//COMMIT_MSG@9 PS5, Line 9: This patch fixes a DCHECK failure > Yes, the DCHECK is in AdmissionController::ComputeGroupScheduleState. Becau Ack http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py@2231 PS7, Line 2231: test_dcheck_issue_coord_statestore_kill_order nit: This can use more clarifying test name. Maybe "test_cluster_membership_after_statestore_recovery" ? http://gerrit.cloudera.org:8080/#/c/23204/7/tests/custom_cluster/test_admission_controller.py@2259 PS7, Line 2259: client2 = coord2.service.create_hs2_client() : handle2 = client2.execute_async(short_query) : # Wait until the second query is confirmed to be queued. : self._wait_for_change_to_profile(handle2, "Admission result: Queued", client=client2) Have you try run this test again after rebase? I did, and the test hang in this part, timing out for not getting queued. -- To view, visit http://gerrit.cloudera.org:8080/23204 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea77347bd4775abd7866817146e326c7c5042f5e Gerrit-Change-Number: 23204 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 24 Sep 2025 17:49:11 +0000 Gerrit-HasComments: Yes
