Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/23528 )
Change subject: IMPALA-12401: Support more info types for HS2 GetInfo() API ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc@116 PS4, Line 116: const string ODBC_KEYWORDS = > These are keywords of Transact-SQL used in SQL Server. Can we just use keyw Yes, so now we are using reflections just like Hive. What hive does is it'll give you Hive SPECIFIC keywords which are present in it's sql-scanner AND NOT present in this ODBC keywords list. We are also now replicating the same behaviour. You can check the case at line 744. http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc@598 PS4, Line 598: 767 > In the initial patch set, we use 128 here which is consistent with Hive: ht Its mentioned in the official impala docs. https://impala.apache.org/docs/build/html/topics/impala_identifiers.html Even Csaba Ringhofer confirmed that the Hive values are wrong and cant be relied on. http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc@665 PS4, Line 665: int32_t > nit: should this be int32_t? max_statement_length_bytes is declared as i32 Done http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc@682 PS4, Line 682: efault > Can we get this from the query option, similar to what we do for 'max_state Done http://gerrit.cloudera.org:8080/#/c/23528/4/be/src/service/impala-hs2-server.cc@699 PS4, Line 699: // so return an empty string (no special chars allowed unquoted). > Impala also supports DROP COLUMN. Should we add SQL_AT_DROP_COLUMN as well? Done http://gerrit.cloudera.org:8080/#/c/23528/4/tests/hs2/test_hs2.py File tests/hs2/test_hs2.py: http://gerrit.cloudera.org:8080/#/c/23528/4/tests/hs2/test_hs2.py@655 PS4, Line 655: > Why using "or" here? Will any of them fail? Done -- To view, visit http://gerrit.cloudera.org:8080/23528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce5f2b9dcc2e4633b4679b002f57b5b4ea3e8bf Gerrit-Change-Number: 23528 Gerrit-PatchSet: 5 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 19:27:30 +0000 Gerrit-HasComments: Yes
