Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23528 )
Change subject: IMPALA-12401: Support more info types for HS2 GetInfo() API ...................................................................... Patch Set 2: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23528/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: http://gerrit.cloudera.org:8080/#/c/23528/2/be/src/service/impala-hs2-server.cc@114 PS2, Line 114: // From https://docs.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql#odbc-reserved-keywords line too long (122 > 90) http://gerrit.cloudera.org:8080/#/c/23528/2/be/src/service/impala-hs2-server.cc@686 PS2, Line 686: // beyond a-z/A-Z/0-9/_. Impala identifiers (unquoted) allow only underscore as "special" line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/23528/2/be/src/service/impala-hs2-server.cc@692 PS2, Line 692: // SQL_NC_HIGH = 2 -> NULLs sort high (Impala treats NULL > all other values by default) line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce5f2b9dcc2e4633b4679b002f57b5b4ea3e8bf Gerrit-Change-Number: 23528 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sun, 12 Oct 2025 16:25:37 +0000 Gerrit-HasComments: Yes
