Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23558 )

Change subject: IMPALA-12870: Tag query id for Java pool threads
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23558/6/be/src/service/fe-support.cc
File be/src/service/fe-support.cc:

http://gerrit.cloudera.org:8080/#/c/23558/6/be/src/service/fe-support.cc@829
PS6, Line 829:     LOG(WARNING) << "ThreadDebugInfo is null. Not tagging query 
id " << PrintId(query_id);
Should this be a DCHECK? Or do we still have gaps?



--
To view, visit http://gerrit.cloudera.org:8080/23558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I83cca55edc72de35f5e8c5422efc104e6aa894c1
Gerrit-Change-Number: 23558
Gerrit-PatchSet: 6
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Mon, 20 Oct 2025 18:57:46 +0000
Gerrit-HasComments: Yes

Reply via email to