Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23558 )
Change subject: IMPALA-12870: Tag query id for Java pool threads ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/23558/6/be/src/service/fe-support.cc File be/src/service/fe-support.cc: http://gerrit.cloudera.org:8080/#/c/23558/6/be/src/service/fe-support.cc@829 PS6, Line 829: LOG(WARNING) << "ThreadDebugInfo is null. Not tagging query id " << PrintId(query_id); > Should this be a DCHECK? Or do we still have gaps? I don't see this log in the tests. Added a DCHECK for this. Left the if-branch unchanged to protect the release build. http://gerrit.cloudera.org:8080/#/c/23558/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/23558/6/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@925 PS6, Line 925: /*queryId*/null > What is your thought about passing default TUniqueId rather than null? Perh We can use ZERO_QUERY_ID here. But the underlying methods still need the null checks since there are some FE test codes that are missing the query id. So maybe using null here is simpler. http://gerrit.cloudera.org:8080/#/c/23558/6/tests/custom_cluster/test_observability.py File tests/custom_cluster/test_observability.py: http://gerrit.cloudera.org:8080/#/c/23558/6/tests/custom_cluster/test_observability.py@57 PS6, Line 57: m > .format() should be cleaner and avoid flake8 errors. Done -- To view, visit http://gerrit.cloudera.org:8080/23558 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I83cca55edc72de35f5e8c5422efc104e6aa894c1 Gerrit-Change-Number: 23558 Gerrit-PatchSet: 7 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 01:33:20 +0000 Gerrit-HasComments: Yes
