Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 1: (11 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@166 PS1, Line 166: throw new AnalysisException("WHERE clause in SHOW PARTITIONS is only supported for HDFS tables"); line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@168 PS1, Line 168: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@174 PS1, Line 174: TableName qualifiedName = new TableName(table_.getDb().getName(), table_.getName()); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@175 PS1, Line 175: TableRef tableRef = new TableRef(qualifiedName.toPath(), null, Privilege.VIEW_METADATA); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@183 PS1, Line 183: throw new AnalysisException("Subqueries are not allowed in SHOW PARTITIONS WHERE"); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@186 PS1, Line 186: throw new AnalysisException("Analytic expressions are not allowed in SHOW PARTITIONS WHERE"); line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@192 PS1, Line 192: throw new AnalysisException("SHOW PARTITIONS WHERE supports only partition columns"); line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@201 PS1, Line 201: org.apache.impala.common.Pair<List<? extends org.apache.impala.catalog.FeFsPartition>, List<Expr>> res = line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@202 PS1, Line 202: pruner.prunePartitions(analyzer, new ArrayList<>(conjuncts), true, tableRef); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/analysis/ShowStatsStmt.java@207 PS1, Line 207: throw new AnalysisException("Failed to evaluate WHERE clause for SHOW PARTITIONS: " + e.getMessage(), e); line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@463 PS1, Line 463: params.isSetFiltered_partition_ids() ? params.getFiltered_partition_ids() : null); line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 11:51:31 +0000 Gerrit-HasComments: Yes
