Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23566 )
Change subject: IMPALA-14065: Support WHERE clause in SHOW PARTITIONS statement ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java File fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: http://gerrit.cloudera.org:8080/#/c/23566/1/fe/src/main/java/org/apache/impala/catalog/FeFsTable.java@581 PS1, Line 581: default TResultSet getTableStatsForPartitions(Collection<Long> partitionIds) { Please try reduce duplicate codes here by extracting common codes against getTableStats(). Have you look at any overrides of FeFsTable.getTableStats()? Do they need to have their own implementation of getTableStatsForPartitions()? $ git grep -B1 'TResultSet getTableStats()' fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java- @Override // FeDataSourceTable fe/src/main/java/org/apache/impala/catalog/DataSourceTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java- // in Frontend.getTableStats? fe/src/main/java/org/apache/impala/catalog/FeDataSourceTable.java: TResultSet getTableStats(); -- fe/src/main/java/org/apache/impala/catalog/FeFsTable.java- */ fe/src/main/java/org/apache/impala/catalog/FeFsTable.java: default TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java- */ fe/src/main/java/org/apache/impala/catalog/FeHBaseTable.java: TResultSet getTableStats(); -- fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java- @Override fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java: default TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/FeSystemTable.java- // in Frontend.getTableStats? fe/src/main/java/org/apache/impala/catalog/FeSystemTable.java: TResultSet getTableStats(); -- fe/src/main/java/org/apache/impala/catalog/HBaseTable.java- @Override fe/src/main/java/org/apache/impala/catalog/HBaseTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/IcebergTimeTravelTable.java- @Override fe/src/main/java/org/apache/impala/catalog/IcebergTimeTravelTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/SystemTable.java- @Override // FeSystemTable fe/src/main/java/org/apache/impala/catalog/SystemTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java- @Override // FeDataSourceTable fe/src/main/java/org/apache/impala/catalog/local/LocalDataSourceTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java- @Override fe/src/main/java/org/apache/impala/catalog/local/LocalHbaseTable.java: public TResultSet getTableStats() { -- fe/src/main/java/org/apache/impala/catalog/local/LocalSystemTable.java- @Override // FeSystemTable fe/src/main/java/org/apache/impala/catalog/local/LocalSystemTable.java: public TResultSet getTableStats() { -- To view, visit http://gerrit.cloudera.org:8080/23566 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e2a14aabcea3fb17083d4ad6f87b7861113f89e Gerrit-Change-Number: 23566 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 30 Oct 2025 16:03:58 +0000 Gerrit-HasComments: Yes
