Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc@224 PS3, Line 224: discard_result(admission_state_map_.Delete(req->query_id())); > Unrelated to this patch but should this be done while holding the admission The admission_state_map_ is ShardedQueryPBMap, which is from GenericShardedQueryMap, it provides a SpinLock per shard to synchronize access to each shard of the map, so should not need extra locks here. https://github.com/apache/impala/blob/420e357b9586b45fbf4d08265fa57dd616989377/be/src/util/sharded-query-map-util.h#L31 -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 00:56:24 +0000 Gerrit-HasComments: Yes
