Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23546 )
Change subject: IMPALA-10204: Make AdmitQuery params more efficient ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23546/3/be/src/scheduling/admission-control-service.cc@224 PS3, Line 224: discard_result(admission_state_map_.Delete(req->query_id())); > I see that admission_state_lock is for admission state members and the shar Yeah, for DD conflicts, the map can sync without other locking. For DU conflicts, the shared_ptr plays a part here, so the D doesn't need the admission state lock. For UU conflicts, it needs the the admission state to sync. -- To view, visit http://gerrit.cloudera.org:8080/23546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ba5e8818336bd1fc3ad604a0acee5eb7a1116c4 Gerrit-Change-Number: 23546 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 16:13:11 +0000 Gerrit-HasComments: Yes
