Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/3/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@571 PS3, Line 571: kuduParamsSql, new Pair<>(innerStmt.getSortColumns(), : innerStmt.getSortingOrder()), properties, innerStmt.getSerdeProperties(), : innerStmt.isExternal(), innerStmt.ge > Thanks for your input Quanlong, yes we were a bit confused about the requir I think either way is OK. But IIRC, we don't have limits like this in the query statement yet. The most similar thing might be query hints. Maybe query option is more flexible, e.g. in the future we can add other options. http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@134 PS6, Line 134: props.remove(StatsSetupConst.DO_NOT_UPDATE_STATS); : : // Hide properties that are materialized elsewhere in DDL : removeHiddenTableProperties(props); : : // Table-format specific filtering : if (table instanceof FeKuduTable) { > These properties are kept hidden from the user in HIDDEN_TABLE_PROPERTIES b Don't need to add all properties in HIDDEN_TABLE_PROPERTIES. I think just NUM_ROWS, NUM_FILES and TOTAL_SIZE is enough. -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 7 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 04:02:44 +0000 Gerrit-HasComments: Yes
