Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23536 )
Change subject: IMPALA-13066: Extend SHOW CREATE TABLE to include stats and partitions ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java File fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java: http://gerrit.cloudera.org:8080/#/c/23536/6/fe/src/main/java/org/apache/impala/analysis/ToSqlUtils.java@134 PS6, Line 134: props.remove(FeTable.CATALOG_SERVICE_ID); : props.remove(FeTable.CATALOG_VERSION); : props.remove(FeTable.LAST_MODIFIED_BY); : props.remove(FeTable.LAST_MODIFIED_TIME); : props.remove(FeFsTable.NUM_ERASURE_CODED_FILES); : props.remove(FeFsTable.NUM_FILES); : props.remove(FeFsTable.TOTAL_SIZE); These removals seems new and do not exist in the old definition of getCreateTableSql(). Is this meant to apply only for SHOW CREATE TABLE WITH ARGS only? Now that I see how many props exist for a table, I wonder if we should limit WITH ARGS only to display NUM_ROWS, NUM_FILES, and TOTAL_SIZE. Planner use that table properties to estimate if table stats does not exist. But I want to defer on Quanlong for that consideration. -- To view, visit http://gerrit.cloudera.org:8080/23536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I87950ae9d9bb73cb2a435cf5bcad076df1570dc2 Gerrit-Change-Number: 23536 Gerrit-PatchSet: 6 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 20 Oct 2025 17:34:28 +0000 Gerrit-HasComments: Yes
