Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23468 )
Change subject: IMPALA-14501: Migrate most scripts from impala-python to impala-python3 ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23468/8/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/23468/8/bin/jenkins/critique-gerrit-review.py@168 PS8, Line 168: raise Exception("Did not expect flake8-diff to write to stderr:\n{0}".format(stderr)) > We're now consistently getting a failure here. Running with verbose output shows $ PATH=`pwd`/gerrit_critic_venv/bin:$PATH flake8-diff --standard-flake8-output HEAD~1 HEAD -v ... 2025-10-22 08:48:35,647 flake8diff.flake8 INFO checking bin/load-data.py lines 1, 223, 253 2025-10-22 08:48:35,742 flake8diff.utils ERROR b"<unknown>:254: SyntaxWarning: invalid escape sequence '\\s'\n" ... 2025-10-22 08:48:37,628 flake8diff.flake8 INFO checking shell/setup.py lines 2025-10-22 08:48:37,700 flake8diff.utils ERROR b"<unknown>:96: SyntaxWarning: invalid escape sequence '\\d'\n<unknown>:104: SyntaxWarning: invalid escape sequence '\\d'\n" -- To view, visit http://gerrit.cloudera.org:8080/23468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If209b761290bc7e7c716c312ea757da3e3bca6dc Gerrit-Change-Number: 23468 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 15:49:44 +0000 Gerrit-HasComments: Yes
