Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23468 )
Change subject: IMPALA-14501: Migrate most scripts from impala-python to impala-python3 ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23468/8/bin/jenkins/critique-gerrit-review.py File bin/jenkins/critique-gerrit-review.py: http://gerrit.cloudera.org:8080/#/c/23468/8/bin/jenkins/critique-gerrit-review.py@168 PS8, Line 168: raise Exception("Did not expect flake8-diff to write to stderr:\n{0}".format(stderr)) > Running with verbose output shows Done http://gerrit.cloudera.org:8080/#/c/23468/8/bin/load-data.py File bin/load-data.py: http://gerrit.cloudera.org:8080/#/c/23468/8/bin/load-data.py@254 PS8, Line 254: match = re.search(r'dataset:\s*([\w\-\.]+)', input_file.read()) > Needs to be a regex literal Done http://gerrit.cloudera.org:8080/#/c/23468/8/shell/setup.py File shell/setup.py: http://gerrit.cloudera.org:8080/#/c/23468/8/shell/setup.py@96 PS8, Line 96: version_match = re.search(r'\d+\.\d+\.\d+', impala_build_version.get_version()) > Need to update this and line 104 to regex literals. Done -- To view, visit http://gerrit.cloudera.org:8080/23468 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If209b761290bc7e7c716c312ea757da3e3bca6dc Gerrit-Change-Number: 23468 Gerrit-PatchSet: 9 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 22 Oct 2025 15:58:06 +0000 Gerrit-HasComments: Yes
