Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23499 )
Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP ...................................................................... Patch Set 13: (3 comments) > Patch Set 13: Code-Review+1 > > (1 comment) http://gerrit.cloudera.org:8080/#/c/23499/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23499/13//COMMIT_MSG@11 PS13, Line 11: preferrable nit: preferable http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/ImpalaHttpClient.py@119 PS13, Line 119: connect_timeout_ms can we mention a comment about internal units here? and why it's ms? http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/impala_shell.py@702 PS13, Line 702: http_socket_timeout_ms can we add a line in the commit message about the unit change in the commit message or a comment? -- To view, visit http://gerrit.cloudera.org:8080/23499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 13 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Mon, 27 Oct 2025 10:05:31 +0000 Gerrit-HasComments: Yes
