Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23499 )
Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/23499/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23499/13//COMMIT_MSG@11 PS13, Line 11: preferrable > nit: preferable Done http://gerrit.cloudera.org:8080/#/c/23499/13//COMMIT_MSG@9 PS13, Line 9: Implements connect_timeout_ms support for HS2-HTTP. This only applies : the timeout while establishing the connection, so later requests do not : timeout. This is preferrable to configuring http_socket_timeout_s, which : can result in timing out operations that just take awhile to execute. > Can you add some comment about this in the code? Done http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/ImpalaHttpClient.py@119 PS13, Line 119: connect_timeout_ms > can we mention a comment about internal units here? and why it's ms? Added on the setTimeout method. http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/impala_shell.py File shell/impala_shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/23499/13/shell/impala_shell/impala_shell.py@702 PS13, Line 702: ter, > can we add a line in the commit message about the unit change in the commit Done -- To view, visit http://gerrit.cloudera.org:8080/23499 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2 Gerrit-Change-Number: 23499 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Fri, 07 Nov 2025 00:45:04 +0000 Gerrit-HasComments: Yes
