Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23603 )
Change subject: IMPALA-13342: Add query-option to dump TExecRequest without executing query ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23603/1/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23603/1/be/src/service/client-request-state.cc@310 PS1, Line 310: serialized_exec_request = apache::thrift::ThriftDebugString(exec_req); Please make sure you don't output sensitive data with ThriftDebugString(). If so, use impala::RedactedDebugString() instead. http://gerrit.cloudera.org:8080/#/c/23603/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23603/1/be/src/service/query-options.h@390 PS1, Line 390: TQueryOptionLevel::DEVELOPMENT) \ line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d5156fed87104bffeb753c57ad405c9f5834ad Gerrit-Change-Number: 23603 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 27 Oct 2025 11:48:23 +0000 Gerrit-HasComments: Yes
