Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23603 )
Change subject: IMPALA-13342: Add query-option to dump TExecRequest without executing query ...................................................................... Patch Set 2: (4 comments) > Patch Set 2: > > Build Successful > > https://jenkins.impala.io/job/gerrit-code-review-checks/20782/ : Initial code > review checks passed. Use gerrit-verify-dryrun-external or > gerrit-verify-dryrun to run full precommit tests. Thanks Arnab! http://gerrit.cloudera.org:8080/#/c/23603/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23603/2//COMMIT_MSG@16 PS2, Line 16: . Add a testing section. Maybe write the different client behaviours, and their compatibilities. http://gerrit.cloudera.org:8080/#/c/23603/2/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/23603/2/be/src/service/client-request-state.cc@310 PS2, Line 310: serialized_exec_request = apache::thrift::ThriftDebugString(exec_req); > Please make sure you don't output sensitive data with ThriftDebugString(). Maybe add a function that masks sensitive data? http://gerrit.cloudera.org:8080/#/c/23603/2/be/src/service/client-request-state.cc@338 PS2, Line 338: ExecState::RUNNING Can you give some rationale behind this? http://gerrit.cloudera.org:8080/#/c/23603/2/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/23603/2/common/thrift/ImpalaService.thrift@1074 PS2, Line 1074: debugging planner issues. Add this in the commit message as well. -- To view, visit http://gerrit.cloudera.org:8080/23603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d5156fed87104bffeb753c57ad405c9f5834ad Gerrit-Change-Number: 23603 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 19:16:54 +0000 Gerrit-HasComments: Yes
