Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23652 )
Change subject: IMPALA-13844: Add /stacks web page to dump native thread stacks ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc@222 PS1, Line 222: if (group[0].status.ok() && group[0].stack.HasCollected()) { Why does this section differ from https://github.com/apache/kudu/blob/d8a95cfcdd8eae9153e1245ede66aaa0b7a1732b/src/kudu/server/default_path_handlers.cc#L223? http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc@405 PS1, Line 405: webserver->RegisterUrlCallback("/stacks", "raw_text.tmpl", StacksHandler, false); Please add a basic test for this endpoint to https://github.com/apache/impala/blob/master/tests/webserver/test_web_pages.py. /jmx might be a good one to model it after. It could also speed up merging to check whether https://github.com/apache/impala/blob/master/tests/custom_cluster/test_web_pages.py has any failures from this change. I don't really expect any, but should be quick to verify. -- To view, visit http://gerrit.cloudera.org:8080/23652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9171c89d1d36726d98a4a61ca040d69254f50e92 Gerrit-Change-Number: 23652 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 17:39:25 +0000 Gerrit-HasComments: Yes
