Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23652 )
Change subject: IMPALA-13844: Add /stacks web page to dump native thread stacks ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc File be/src/util/default-path-handlers.cc: http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc@222 PS1, Line 222: if (group[0].status.ok() && group[0].stack.HasCollected()) { > It provides better error handling, the Kudu counterpart doesnt take care of Ack http://gerrit.cloudera.org:8080/#/c/23652/1/be/src/util/default-path-handlers.cc@405 PS1, Line 405: webserver->RegisterUrlCallback("/stacks", "raw_text.tmpl", StacksHandler, false); > Done Ack http://gerrit.cloudera.org:8080/#/c/23652/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/23652/2/tests/webserver/test_web_pages.py@230 PS2, Line 230: input_url = self.STACKS_URL.format(self.IMPALAD_TEST_PORT[0]) I don't think these format checks would be expensive to do on every daemon. These are also fine though. -- To view, visit http://gerrit.cloudera.org:8080/23652 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9171c89d1d36726d98a4a61ca040d69254f50e92 Gerrit-Change-Number: 23652 Gerrit-PatchSet: 2 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:14:04 +0000 Gerrit-HasComments: Yes
