Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23475/2/be/src/exprs/string-functions.cc File be/src/exprs/string-functions.cc: http://gerrit.cloudera.org:8080/#/c/23475/2/be/src/exprs/string-functions.cc@363 PS2, Line 363: " Should we also support single quotes? http://gerrit.cloudera.org:8080/#/c/23475/2/be/src/exprs/string-functions.cc@366 PS2, Line 366: nit: please align these http://gerrit.cloudera.org:8080/#/c/23475/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/23475/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3144 PS2, Line 3144: "a.com" Can we add some negative tests like using "a."com where not all parts of the key are quoted? Also does it mean anything can be quoted as a key, e.g. "a[0]", "$100" ? -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 02:32:56 +0000 Gerrit-HasComments: Yes
