Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23475 )
Change subject: IMPALA-14467: Support quoted keys with dots in get_json_object path strings ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/23475/2/be/src/util/string-util.cc File be/src/util/string-util.cc: http://gerrit.cloudera.org:8080/#/c/23475/2/be/src/util/string-util.cc@118 PS2, Line 118: return p - start + 1; Can you please explain about the function in a comment, what it returns and what does start and other variables point to? http://gerrit.cloudera.org:8080/#/c/23475/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test File testdata/workloads/functional-query/queries/QueryTest/exprs.test: http://gerrit.cloudera.org:8080/#/c/23475/2/testdata/workloads/functional-query/queries/QueryTest/exprs.test@3149 PS2, Line 3149: : ---- QUERY Add a test of an empty string within "", do we want to treat that as a valid case now? -- To view, visit http://gerrit.cloudera.org:8080/23475 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3618d9e029501f9ac0e23190feb8263968b1b9f Gerrit-Change-Number: 23475 Gerrit-PatchSet: 2 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 20:04:34 +0000 Gerrit-HasComments: Yes
