Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/23226 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 11: (2 comments) Thanks Michael! http://gerrit.cloudera.org:8080/#/c/23226/11/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23226/11/shell/impala_shell/ImpalaHttpClient.py@417 PS11, Line 417: e.errno != errno.EPIPE Would it make sense to account for connection reset cases as well here? http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py@94 PS11, Line 94: # counting total number of RPCs is not trivial or stable, so ensure we have multiple. > I agree this approach is good enough. The assert in line 90 is the most im Is there a rationale on taking "10" here? might be good to have a comment about it too. -- To view, visit http://gerrit.cloudera.org:8080/23226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a6c4f175cceca80f530b4d4355316d588730f0 Gerrit-Change-Number: 23226 Gerrit-PatchSet: 11 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Tue, 11 Nov 2025 02:37:23 +0000 Gerrit-HasComments: Yes
