Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23226 )
Change subject: IMPALA-14460: Keep http connections open in impala-shell ...................................................................... Patch Set 13: (3 comments) Looks good! I would like to see the following comments addressed if there are going to be changes or noted with a "not doing" if there will be no more changes. https://gerrit.cloudera.org/c/23226/11/shell/impala_shell/ImpalaHttpClient.py#428 https://gerrit.cloudera.org/c/23226/11/shell/impala_shell/ImpalaHttpClient.py#417 http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_jwt_auth.py@179 PS11, Line 179: self.__wait_for > Nit: Please consider changing this variable name to be "query_connection_co Done http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py File tests/custom_cluster/test_shell_oauth_auth.py: http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py@135 PS11, Line 135: self.__wait_for > Done Done http://gerrit.cloudera.org:8080/#/c/23226/11/tests/custom_cluster/test_shell_oauth_auth.py@179 PS11, Line 179: self.__wait_for_connection_count(before_connection_count + 1) > Done Done -- To view, visit http://gerrit.cloudera.org:8080/23226 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If7a6c4f175cceca80f530b4d4355316d588730f0 Gerrit-Change-Number: 23226 Gerrit-PatchSet: 13 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 17:15:44 +0000 Gerrit-HasComments: Yes
