Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@220 PS8, Line 220: // Need to disableResultSpooling if spoolResults_ is set to false so that : // the query option 'spool_query_results' is set to false. : disableResultSpooling(queryOptions); > Just gonna comment here but this is relevant to a lot of the comments... This patch make the decision of spooling vs not spooling early on at CalciteSingleNodePlanner.createDataSink() and SingleNodePlanner.createDataSink(). I feel like it is important to make spoolResults_ and queryOptions.isSpool_query_results() consistent from the beginning (constructor). Otherwise, we risking introducing future bug where there is a split brain problem between both state. CalciteSingleNodePlanner.createDataSink() looks definitely wrong to me, because if returnsMoreThanOneRow_ is False, then both spoolResults_ and queryOptions.isSpool_query_results() should be False too coming into this class constructor. -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 12 Nov 2025 21:52:10 +0000 Gerrit-HasComments: Yes
