Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23562 )
Change subject: IMPALA-13902: Calcite planner: Implement is_spool_query_results ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java File fe/src/main/java/org/apache/impala/planner/PlanRootSink.java: http://gerrit.cloudera.org:8080/#/c/23562/8/fe/src/main/java/org/apache/impala/planner/PlanRootSink.java@220 PS8, Line 220: // Need to disableResultSpooling if spoolResults_ is set to false so that : // the query option 'spool_query_results' is set to false. : disableResultSpooling(queryOptions); > Still makes me nervous that "computeResourceProfile" will always be the las I uploaded a couple of changes trying to follow your guidelines but I took some additional steps... 1) I actually had a bug in QueryStmt where I was setting spoolResults to False when there was more than 1 row. I had not done full regression testing and that prolly would have shown up 2) i didn't like that "instanceof SelectStmt", so I changed that logic with an override. I forgot to put in a comment in the base class, will do so after this comment 3) As I mentioned, I did not like setting QueryOptions in multiple places. I isolated this into one place. Still think it belongs in Frontend, but I can live with this, I hope you can too. 4) I did not touch the bug you found in that computeProcessingCost is run too early. That can be in a another commit, but I will put in a comment there on next upload. 5) I think I should do a full regression run right now. I made one other very small change which looked right? But I'm nervous about it. The SingleNodePlanner calls getQueryStmt on 2 different objects. I hope they're the same? If not, something will go wrong. But I picked the one off of AnalysisResult because that seems more right to me. -- To view, visit http://gerrit.cloudera.org:8080/23562 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b9bf49e2874ee12de212b892bd898c296774c6f Gerrit-Change-Number: 23562 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:07:48 +0000 Gerrit-HasComments: Yes
