Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23528 )
Change subject: IMPALA-12401: Support more info types for HS2 GetInfo() API ...................................................................... Patch Set 8: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23528/8/be/src/service/odbc-helper.h File be/src/service/odbc-helper.h: http://gerrit.cloudera.org:8080/#/c/23528/8/be/src/service/odbc-helper.h@29 PS8, Line 29: /// From https://docs.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql#odbc-reserved-keywords line too long (123 > 90) http://gerrit.cloudera.org:8080/#/c/23528/8/be/src/service/odbc-helper.cc File be/src/service/odbc-helper.cc: http://gerrit.cloudera.org:8080/#/c/23528/8/be/src/service/odbc-helper.cc@36 PS8, Line 36: // From https://docs.microsoft.com/en-us/sql/t-sql/language-elements/reserved-keywords-transact-sql#odbc-reserved-keywords line too long (122 > 90) -- To view, visit http://gerrit.cloudera.org:8080/23528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ce5f2b9dcc2e4633b4679b002f57b5b4ea3e8bf Gerrit-Change-Number: 23528 Gerrit-PatchSet: 8 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 16:59:00 +0000 Gerrit-HasComments: Yes
