Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23671
Change subject: IMPALA-14552: test_show_create_table should be more strict with TBLPROPERTIES contents ...................................................................... IMPALA-14552: test_show_create_table should be more strict with TBLPROPERTIES contents Currently we use this regex to parse the contents of TBLPROPERTIES: kv_regex = "'([^\']+)'\\s*=\\s*'([^\']+)'" kv_results = dict(re.findall(kv_regex, map_match.group(1))) This allows strings like: 'X'='Y'='Z' 'X'='Z'$'A'='B' This means it's easy to write strings in .test files that are not valid SQL. This patch adds a few extra checks to validate the TBLPROPERTIES contents. Change-Id: I94110f50720c01dc7807ee56c794d235f4990282 --- M tests/metadata/test_show_create_table.py 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/71/23671/1 -- To view, visit http://gerrit.cloudera.org:8080/23671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I94110f50720c01dc7807ee56c794d235f4990282 Gerrit-Change-Number: 23671 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
