Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/23671 )
Change subject: IMPALA-14552: test_show_create_table should be more strict with TBLPROPERTIES contents ...................................................................... Patch Set 2: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/23671/1/tests/metadata/test_show_create_table.py File tests/metadata/test_show_create_table.py: http://gerrit.cloudera.org:8080/#/c/23671/1/tests/metadata/test_show_create_table.py@45 PS1, Line 45: '([^']*)'\s*=\s*'([^']*)'\s*(?:,|$) > does this allow doubled single quotes? Good catch. Updated the regex so it accepts ''='', 'x'='', ''='x'. http://gerrit.cloudera.org:8080/#/c/23671/1/tests/metadata/test_show_create_table.py@48 PS1, Line 48: [TBL|SERDE]PR > nit: TBLPROPERTIES / SERDEPROPERTIES Done -- To view, visit http://gerrit.cloudera.org:8080/23671 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94110f50720c01dc7807ee56c794d235f4990282 Gerrit-Change-Number: 23671 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 13 Nov 2025 17:39:40 +0000 Gerrit-HasComments: Yes
