Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23688 )
Change subject: IMPALA-14540: Fix dump_breakpad_symbols.py's -b option and add tests ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/23688/1/bin/dump_breakpad_symbols.py File bin/dump_breakpad_symbols.py: http://gerrit.cloudera.org:8080/#/c/23688/1/bin/dump_breakpad_symbols.py@258 PS1, Line 258: def assert_binaries_exist(args): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/23688/1/bin/dump_breakpad_symbols.py@259 PS1, Line 259: " flake8: E501 line too long (92 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/23688 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8596e994b9d15be33d99e91ecc38f87c22545a08 Gerrit-Change-Number: 23688 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 01:34:48 +0000 Gerrit-HasComments: Yes
