Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/23688
to look at the new patch set (#2).
Change subject: IMPALA-14540: Fix dump_breakpad_symbols.py's -b option and add
tests
......................................................................
IMPALA-14540: Fix dump_breakpad_symbols.py's -b option and add tests
When dump_breakpad_symbols.py switched to Python 3, the -b
option, which specifies a build directory, broke due to
Python 3's distinction between bytes and strings. This impacts
the bin/jenkins/finalize.sh script that runs at the end of
Jenkins jobs.
This fixes the -b option and adds tests for basic scenarios
for dump_breakpad_symbols.py. Specifically, it tests positive
scenarios for -b (build directory), -f (specific binary), and
-i (list provided via stdin). This adds additional validation
of dump_breakpad_symbols.py's inputs (e.g. verifying that the
file/directory exists, etc) and adds negative test cases for
that validation.
Testing:
- Ran new pytests locally
Change-Id: I8596e994b9d15be33d99e91ecc38f87c22545a08
---
M bin/dump_breakpad_symbols.py
A tests/infra/test_breakpad_symbols.py
2 files changed, 113 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/23688/2
--
To view, visit http://gerrit.cloudera.org:8080/23688
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8596e994b9d15be33d99e91ecc38f87c22545a08
Gerrit-Change-Number: 23688
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
